Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE
Date
Msg-id 20180920224624.toqzjvgn6ivmrwud@alap3.anarazel.de
Whole thread Raw
In response to Re: Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2018-09-20 18:38:36 -0400, Tom Lane wrote:
> Thomas Munro <thomas.munro@enterprisedb.com> writes:
> > . o O ( hmm, we now have variadic macros )
> 
> hmmm ... but even with variadic, C's macro facility is so weak that
> I'm not sure we can reimplement these with it.  What would the
> expansion look like?

There's a dirty hack to count arguments in vararg macros:
https://groups.google.com/d/msg/comp.std.c/d-6Mj5Lko_s/5fW1bP6T3RIJ

Afaict that ought to be enough to implement something like the current
macros? Whether that's too ugly or not, I don't know.


> It constantly annoys me that C's so weak here.

Yea. Weak and fragile, both.


Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE