Re: pgsql: Allow concurrent-safe open() and fopen() in frontend codefor Wi - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Allow concurrent-safe open() and fopen() in frontend codefor Wi
Date
Msg-id 20180914224939.GA1178@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Allow concurrent-safe open() and fopen() in frontend codefor Wi  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
On Fri, Sep 14, 2018 at 11:22:55AM -0400, Tom Lane wrote:
> I'm surprised you didn't back-patch this --- isn't it a bug fix?
>
> A compromise might be to push it to v11 but not further.

Yes, that's clearly a bug fix from pg_ctl point of view with TAP tests.
However, I have rather cold feet about back-patching for two reasons as
this introduces a behavior change:
- The concurrency part disappears.
- Caller of open() needs to enforce text mode to strip correctly CRLF
characters.

I would be fine to get that into v11 though, as that is not released
yet.  You will have to wait for a couple of days though, there is a long
week-end here away from laptops and electronic devices ;)
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Move PartitionDispatchData struct definition to execPartition.c
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Move PartitionDispatchData struct definition to execPartition.c