Re: Loaded footgun open_datasync on Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Loaded footgun open_datasync on Windows
Date
Msg-id 20180914073147.GJ29332@paquier.xyz
Whole thread Raw
In response to Re: Loaded footgun open_datasync on Windows  (Laurenz Albe <laurenz.albe@cybertec.at>)
Responses Re: Loaded footgun open_datasync on Windows  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
On Fri, Sep 14, 2018 at 08:43:18AM +0200, Laurenz Albe wrote:
> Thanks for being interested and doing the work.

No problem.  I have a sort of Windows-label stuck on me for ages, and
those random buildfarm failures are annoying with TAP tests on Windows.

> If it turns out not to break anything, would you consider backpatching?
> On the one hand it fixes a bug, on the other hand it affects all
> frontend executables...

Yeah, for this reason I would not do a backpatch.  I have a very hard
time to believe that any frontend tools on Windows developed by anybody
rely on files to be opened only by a single process, still if they do
they would be surprised to see a change of behavior after a minor
update in case they rely on the concurrency limitations.

> I wonder why nobody noticed the problem in pg_test_fsync earlier.
> Is it that people running Windows care less if their storage is
> reliable?

likely so.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: 李海龙
Date:
Subject: when set track_commit_timestamp on, database system abort startup
Next
From: Masahiko Sawada
Date:
Subject: Re: Changing the setting of wal_sender_timeout per standby