Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
Date
Msg-id 20180908193158.GH32058@paquier.xyz
Whole thread Raw
In response to Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
On Sat, Sep 08, 2018 at 07:56:23AM -0400, Tom Lane wrote:
> Looking closer, there are no leaks, though I think we could use a comment
> about that.  And it still makes me itch that pg_saslprep (mostly) doesn't
> worry about clearing *output on failure while only three of its four
> callers bother to initialize their variables to null.  That's a recipe
> for future bugs.  So I propose the attached cleanup.

Okay, that looks acceptable to me.  Thanks for looking at that.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
Next
From: Michael Paquier
Date:
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables