Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.
Date
Msg-id 20180904205818.GH20696@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Tue, Sep 04, 2018 at 03:16:55PM -0400, Tom Lane wrote:
> Why would we invent a different target name?  I was thinking something
> roughly like
>
> check: submake $(REGRESS_PREP)
> ifdef REGRESS
>     $(pg_regress_check) $(REGRESS_OPTS) $(REGRESS)
> endif
> ifdef TAP_TESTS
>     $(prove_check)
> endif
>
> although getting it to print a useful response when neither symbol
> is set would require complicating things a bit.  Still, as long as
> there's just one copy of this rule, messiness isn't a big problem.

OK.  I have dug into that, and finished with the attached.  What do you
think?  One thing is that the definition of submake is moving out of
REGRESS, and .PHONY gets defined.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.
Next
From: Bruce Momjian
Date:
Subject: pgsql: docs: improve AT TIME ZONE description