Re: libpq should append auth failures, not overwrite - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: libpq should append auth failures, not overwrite
Date
Msg-id 20180809161453.GI13638@paquier.xyz
Whole thread Raw
In response to libpq should append auth failures, not overwrite  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: libpq should append auth failures, not overwrite
List pgsql-hackers
On Thu, Aug 09, 2018 at 11:44:27AM -0400, Tom Lane wrote:
> I noticed that, although most error reports during libpq's connection
> setup code append to conn->errorMessage, the ones in fe-auth.c and
> fe-auth-scram.c don't: they're all printfPQExpBuffer() not
> appendPQExpBuffer().  This seems wrong to me.  It makes no difference
> in simple cases with a single target server, but as soon as you have
> multiple servers listed in "host", this coding makes it impossible
> to tell which server rejected your login.

+1.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: found xmin from before relfrozenxid on pg_catalog.pg_authid
Next
From: Andrew Dunstan
Date:
Subject: Commitfest 2018-07 RFC items