Re: Remove psql's -W option - Mailing list pgsql-hackers

From David Fetter
Subject Re: Remove psql's -W option
Date
Msg-id 20180723152810.GJ29917@fetter.org
Whole thread Raw
In response to Re: Remove psql's -W option  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Mon, Jul 23, 2018 at 11:20:46AM -0400, Robert Haas wrote:
> On Sun, Jul 22, 2018 at 9:35 AM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
> > Otherwise ISTM that "-W/--password" still has some minimal value thus does
> > not deserve to be thrown out that quickly.
> 
> I think I agree.  I don't think this option is really hurting
> anything, so I'm not quite sure why we would want to abruptly get rid
> of it.
> 
> I also think your other question is a good one.  It seems like the
> fact that we need to reconnect -- rather than just prompting for the
> password and then sending it when we get it -- is an artifact of how
> libpq is designed rather than an intrinsic limitation of the protocol.

Am I understanding correctly that doing the following would be
acceptable, assuming good code quality?

- Rearrange libpq so it doesn't force this behavior.
- Deprecate the -W option uniformly in the code we ship by documenting
  it and making it send warnings to stderr.

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: How can we submit code patches that implement our (pending)patents?
Next
From: Robert Haas
Date:
Subject: Re: BUG #15182: Canceling authentication due to timeout aka Denial ofService Attack