Re: print_path is missing GatherMerge and CustomScan support - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: print_path is missing GatherMerge and CustomScan support
Date
Msg-id 20180718065524.GE8565@paquier.xyz
Whole thread Raw
In response to Re: print_path is missing GatherMerge and CustomScan support  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
On Wed, Jul 18, 2018 at 12:15:25PM +0530, Ashutosh Bapat wrote:
> On Wed, Jul 18, 2018 at 11:52 AM, Michael Paquier <michael@paquier.xyz> wrote:
>> On Wed, Jul 18, 2018 at 02:35:23PM +0900, Masahiko Sawada wrote:
>>> Hi,
>>>
>>> While debugging planner I realized that print_path() function is not
>>> aware of both GatherMerge path and CustomScan path. Attached small
>>> patch fixes it.
>>
>> Good catch.  Those should be backpatched.  While I am looking at this
>> stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
>> T_MergeAppend and not T_MergeAppendPath.
>>
>> This is new as of f49842d1 in v11.
>
> Yes that's right. Thanks for taking care of it.

Thanks for the confirmation.  Robert, do you want to take care of this
issue or should I?

>> Robert, Ashutosh, am I missing
>> something?
>
> You used my personal email id by mistake, I think. I have removed it
> and added by EDB email address.

My sincere apologies.  I have not been careful.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: print_path is missing GatherMerge and CustomScan support
Next
From: Craig Ringer
Date:
Subject: Re: [bug fix] Produce a crash dump before main() on Windows