More consistency for some file-related error message - Mailing list pgsql-hackers

From Michael Paquier
Subject More consistency for some file-related error message
Date
Msg-id 20180718044711.GA8565@paquier.xyz
Whole thread Raw
Responses Re: More consistency for some file-related error message  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi all,

While looking at the source code for more consistency work with error
messages, I have bumped into a couple of messages which could be
simplified, as those include in the name of the file manipulated
basically the same information as the context added.

I have finished with the attached.  Note that for most of the messages,
I think that the context can be useful, like for example the stats
temporary file which could be user-defined, so those are left out.
There are also other cases, say the reorder buffer spill file, where we
may not know the path worked on, so the messages are kept consistent as
per HEAD.

That's a bit less work to do for translators, particularly with
pg_stat_statements.

Thoughts?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: Make foo=null a warning by default.
Next
From: Andrey Borodin
Date:
Subject: Re: GSOC 2018 Project - A New Sorting Routine