Re: pg_create_logical_replication_slot returns text instead of name - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_create_logical_replication_slot returns text instead of name
Date
Msg-id 20180712131853.GD1167@paquier.xyz
Whole thread Raw
In response to pg_create_logical_replication_slot returns text instead of name  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: pg_create_logical_replication_slot returns text instead of name  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, Jul 12, 2018 at 07:00:48PM +0900, Masahiko Sawada wrote:
> The documentation[1] says that both pg_create_logical_replication_slot
> and pg_create_physical_replication_slot returns slot_name as a name
> type. But only pg_create_logical_replication_slot returns it as text
> type. I think these should be united as the name type. Attached small
> patch fixes it.
>
> [1] https://www.postgresql.org/docs/devel/static/functions-admin.html#FUNCTIONS-REPLICATION

That's a small thing, but I agree with you.  As far as I can see slot
names are always mapped with the name type.  I'll push that tomorrow if
there are no objections.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Negotiating the SCRAM channel binding type
Next
From: Tom Lane
Date:
Subject: Re: Binary difference in pg_internal.init after running pg_initdb multiple times