Re: Let's remove DSM_IMPL_NONE. - Mailing list pgsql-hackers

On Fri, Jul 06, 2018 at 11:08:02PM +0200, Peter Eisentraut wrote:
> On 26.06.18 09:10, Kyotaro HORIGUCHI wrote:
>> --- a/src/include/storage/dsm_impl.h
>> +++ b/src/include/storage/dsm_impl.h
>> @@ -14,11 +14,10 @@
>>  #define DSM_IMPL_H
>>
>>  /* Dynamic shared memory implementations. */
>> -#define DSM_IMPL_NONE            0
>> -#define DSM_IMPL_POSIX            1
>> -#define DSM_IMPL_SYSV            2
>> -#define DSM_IMPL_WINDOWS        3
>> -#define DSM_IMPL_MMAP            4
>> +#define DSM_IMPL_POSIX            0
>> +#define DSM_IMPL_SYSV            1
>> +#define DSM_IMPL_WINDOWS        2
>> +#define DSM_IMPL_MMAP            3
>
> I would avoid renumbering here.  It was kind of sensible to have NONE =
> 0, so I'd keep the non-NONE ones as non-zero.

+1.
--
Michael