Re: XLogSegNoOffsetToRecPtr fixup - Mailing list pgsql-hackers

From Andres Freund
Subject Re: XLogSegNoOffsetToRecPtr fixup
Date
Msg-id 20180708182749.ruetnwjmroui2svk@alap3.anarazel.de
Whole thread Raw
In response to XLogSegNoOffsetToRecPtr fixup  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Hi,

On 2018-07-08 14:23:45 -0400, Alvaro Herrera wrote:
> Pursuant to closing comment in 
> https://postgr.es/m/20180306214239.ospkf6ie7aa5gm4j@alvherre.pgsql
> here's a quick patch to change the order of arguments in
> XLogSegNoOffsetToRecPtr.  Commit fc49e24fa69a ("Make WAL segment size
> configurable at initdb time.") put the walsegsz as last argument,
> *after* its output argument, which is downright weird.
> 
> I propose to apply this to pg11 and master, to avoid an unnecessary API
> change in pg12.

WFM.

Thanks,

Andres


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: XLogSegNoOffsetToRecPtr fixup
Next
From: Noah Misch
Date:
Subject: Re: hot_standby_feedback vs excludeVacuum and snapshots