Re: pgsql: Use access() to check file existence inGetNewRelFileNode() - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Use access() to check file existence inGetNewRelFileNode()
Date
Msg-id 20180708172733.pwomywupfcwiylby@alap3.anarazel.de
Whole thread Raw
In response to Re: pgsql: Use access() to check file existence inGetNewRelFileNode()  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: pgsql: Use access() to check file existence inGetNewRelFileNode()
List pgsql-committers
Hi,

On 2018-07-08 10:05:53 -0400, Andrew Dunstan wrote:
> On 07/08/2018 06:00 AM, Michael Paquier wrote:
> > Reviewed-by: Peter Eisentraut, Michael Paquier
> > 
> 
> I think if you're the committer you're assumed to have reviewed the patch
> :-)

I personally think it makes sense to put oneself there. At least I order
the Reviewed-By etc lists roughly by the amount of work done. Sometimes
you come across a patch where others have done most of the review work,
so it's sensible to put yourself last. In other cases you might have
spent months of effort - so first.

Greetings,

Andres Freund


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Use access() to check file existence inGetNewRelFileNode()
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Correct obsolete unique index insertion comment.