Re: PATCH: Update snowball stemmers - Mailing list pgsql-hackers

From Arthur Zakirov
Subject Re: PATCH: Update snowball stemmers
Date
Msg-id 20180706191701.GA2516@artur-book.localdomain
Whole thread Raw
In response to Re: PATCH: Update snowball stemmers  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: PATCH: Update snowball stemmers
List pgsql-hackers
On Fri, Jul 06, 2018 at 12:37:26PM -0400, Tom Lane wrote:
> > I don't know if we have a buildfarm animal testing Hungarian. Maybe we 
> > need a buildfarm animal or two testing a large number of locales.
> 
> I dunno that we need to set up a permanent buildfarm member for this.
> I had been thinking in terms of testing every available locale on my
> own machines before pushing, but given that the code is pretty static,
> do we need to do that repetitively?

I run installcheck for hu_HU.UTF-8, hu_HU.ISO-8859-2 and ru_RU.UTF-8
locales on laptop. Tests passed.

I think it is worth to consider that most text search functions
(to_tsvector, to_tsquery) use specific text search configuration (english
or a custom one). Only few of them use default text search configuration.
They are in json.sql, jsonb.sql, tsearch.sql tests.

Is it good idea to modify some current tests to use default configuration
or to add specific tests for locale testing?

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


pgsql-hackers by date:

Previous
From: Dave Cramer
Date:
Subject: Re: pg_recvlogical use of SIGHUP
Next
From: Alvaro Herrera
Date:
Subject: Re: documentation fixes for partition pruning, round three