Re: Should contrib modules install .h files? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Should contrib modules install .h files?
Date
Msg-id 20180706014507.GD2366@paquier.xyz
Whole thread Raw
In response to Re: Should contrib modules install .h files?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Jul 04, 2018 at 05:00:56PM -0400, Tom Lane wrote:
> Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
>> This installs to $(includedir_server)/$(MODULEDIR)/$MODULE/file.h
>> (e.g. include/server/extension/hstore/hstore.h for an actual example),
>> and errors if HEADERS_xxx is defined for anything that's not a module
>> listed in MODULES or MODULE_big.
>
> I've not studied this patch in any great detail, but the basic plan seems
> sane.  However, don't we also need to teach the MSVC build system about
> this?

+1.  I have not looked at this patch in details myself, but the concept
looks good.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Should contrib modules install .h files?
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Optional message to user when terminating/cancellingbackend