Re: Non-reserved replication slots and slot advancing - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Non-reserved replication slots and slot advancing
Date
Msg-id 20180705031920.GC29020@paquier.xyz
Whole thread Raw
In response to Re: Non-reserved replication slots and slot advancing  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Non-reserved replication slots and slot advancing  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Wed, Jul 04, 2018 at 09:57:31AM -0400, Alvaro Herrera wrote:
> None from me.

Thanks Alvaro.  For now the patch uses the following error message:
+SELECT pg_replication_slot_advance('regression_slot3', '0/1'); -- error
+ERROR:  cannot move slot with non-reserved restart_lsn

Mentioning directly the column name of pg_replication_slots is confusing
I think.  Here are some suggestions of perhaps better error messages:
1) cannot move unreserved slot.
2) cannot move slot which has never been reserved.

Any better ideas?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Old small commitfest items
Next
From: Michael Paquier
Date:
Subject: Re: Speedup of relation deletes during recovery