Re: pgsql: Add wait event for fsync of WAL segments - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Add wait event for fsync of WAL segments
Date
Msg-id 20180703223220.GA1672@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Add wait event for fsync of WAL segments  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-committers
On Tue, Jul 03, 2018 at 04:12:23PM -0400, Alvaro Herrera wrote:
> On 2018-Jul-03, Andres Freund wrote:
>
> > On 2018-07-03 15:13:20 -0400, Alvaro Herrera wrote:
> > > Are the numerical values actually exposed to the world?  I thought the
> > > only way to this info was through the system views, which surely expose
> > > the names, not the numbers.
> >
> > There's at least some work at high frequency sampling of these, and I
> > assume that's not going through SQL, but rather C functions.
>
> You're right.

My take is a background worker which connects to shared memory and scans
directly ProcArray entries.

> Anyway, it's not a huge deal to me.  If Michael doesn't want to
> backpatch it, it's his call, and I don't have the cycles to do it myself
> right now either.  If some other committer cares about it, well ...

New wait events on HEAD are adapted to HEAD in my opinion, so I would
keep the code as it is now.  If anybody wishes to back-patch the change,
of course feel free to do so.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Add $Test::Builder::Level to pgbench test functions
Next
From: Amit Langote
Date:
Subject: Re: pgsql: Clarify use of temporary tables within partition trees