Re: Speedup of relation deletes during recovery - Mailing list pgsql-hackers

On Tue, Jul 03, 2018 at 04:13:15AM +0900, Fujii Masao wrote:
> OK, so what about the attached patch?

I have been looking at this patch, and this looks in good shape to me
(please indent!).

+    * Call smgrclose() in reverse order as when smgropen() is called.
+    * This trick enables remove_from_unowned_list() in smgrclose()
+    * to search the SMgrRelation from the unowned list,
+    * in O(1) performance.

A nit here: with O(1) performance.

Could it be possible to add an assertion so as isRedo is never enabled
out of recovery?
--
Michael