Re: Typo in llvm_function_reference - Mailing list pgsql-hackers

Hi,

On 2018-06-27 10:46:35 +0530, Rushabh Lathia wrote:
> There is multiple return statement in llvm_function_reference
> and that's definitely looks typo. Here is the patch to fix the
> same.

> diff --git a/src/backend/jit/llvm/llvmjit.c b/src/backend/jit/llvm/llvmjit.c
> index daae964..5d0cdab 100644
> --- a/src/backend/jit/llvm/llvmjit.c
> +++ b/src/backend/jit/llvm/llvmjit.c
> @@ -394,7 +394,6 @@ llvm_function_reference(LLVMJitContext *context,
>          LLVMSetGlobalConstant(v_fn, true);
>  
>          return LLVMBuildLoad(builder, v_fn, "");
> -        return v_fn;
>      }
>  
>      /* check if function already has been added */

Thanks! Pushed.

Greetings,

Andres Freund