Re: BUG #15252: "do not dump comments" in pg_restore help - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #15252: "do not dump comments" in pg_restore help
Date
Msg-id 20180626060204.GE31353@paquier.xyz
Whole thread Raw
In response to Re: BUG #15252: "do not dump comments" in pg_restore help  (Sergei Kornilov <sk@zsrv.org>)
List pgsql-bugs
On Mon, Jun 25, 2018 at 01:26:38PM +0300, Sergei Kornilov wrote:
> Thank you! I recheck behavior too, option works correct and has only
> wrong description. Simple patch attached.

This is clearly a copy-pasto from recent commit 1368e92, nice catch.

>        <listitem>
>         <para>
> -        Do not dump comments.
> +        Do not restore comments.
>         </para>
>        </listitem>
>       </varlistentry>

This is not consistent with the other --no-XXX switches, so I have
reworded the documentation fix to be more consistent with the rest and
pushed the patch.  I can confirm as well after some manual testing that
the feature behaves as documented.

Thanks for the report and the patch!
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Converting to UTC multiple times converts back to local time zone
Next
From: Pash Ebash
Date:
Subject: Found incorrect output in pg_lsclusters