Re: Incorrect fsync handling in pg_basebackup's tar_finish - Mailing list pgsql-hackers

On Mon, Jun 25, 2018 at 05:48:54PM +0530, Kuntal Ghosh wrote:
> In the same note, in tar_close(), we fsync on close. We're not
> checking the status of fsync there. Should we introduce the same check
> there as well?

Yes, there is a second one.  I just looked at walmethods.c and I did not
spot any other issues.  What do you think about the updated version
attached?
--
Michael