Re: pgsql: Store 2PC GID in commit/abort WAL recs for logicaldecoding - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pgsql: Store 2PC GID in commit/abort WAL recs for logicaldecoding
Date
Msg-id 20180620162342.zfpxeriuk4oafxln@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Store 2PC GID in commit/abort WAL recs for logicaldecoding  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 2018-Jun-15, Alvaro Herrera wrote:

> By the way, why do we need to strlen() the target buffer when strlcpy
> already reports the length?  (You could argue that there is a difference
> if the string is truncated ... but surely we don't care about that case)
> I propose the attached.

I decided not to push this after all.  Yes, one strlen is saved, but
there is some code clarity lost also, and this is certainly not a
contention point.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: line numbers in error messages are off wrt debuggers
Next
From: Andres Freund
Date:
Subject: Re: line numbers in error messages are off wrt debuggers