Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Find additional connection service files inpg_service.conf.d directory - Mailing list pgsql-hackers

From Arthur Zakirov
Subject Re: [PATCH] Find additional connection service files inpg_service.conf.d directory
Date
Msg-id 20180618161712.GA2086@zakirov.localdomain
Whole thread Raw
In response to Re: [PATCH] Find additional connection service files inpg_service.conf.d directory  (Curt Tilmes <curt@tilmes.org>)
Responses Re: [PATCH] Find additional connection service files inpg_service.conf.d directory
Re: [PATCH] Find additional connection service files inpg_service.conf.d directory
List pgsql-hackers
Tree view 
Hello,

On Thu, Mar 01, 2018 at 01:40:10PM -0500, Curt Tilmes wrote:
> New patch limits files to ".conf".

Isn't it worth to check errno for stat(), opendir() and readdir() calls?

I think when some error occured in searchServiceFileDirectory() then the
error "definition of service \"%s\" not found" will be raised, because
group_found is false. It may confuse as it hides a real error. For
example, if permission is denied to open the directory.

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Server crashed with TRAP: FailedAssertion("!(parallel_workers >0)" when partitionwise_aggregate true.
Next
From: Tomas Vondra
Date:
Subject: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)