Re: pgsql: Store 2PC GID in commit/abort WAL recs for logicaldecoding - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pgsql: Store 2PC GID in commit/abort WAL recs for logicaldecoding
Date
Msg-id 20180615190457.fpjrfwhfoke33c3j@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding  (Nikhil Sontakke <nikhils@2ndquadrant.com>)
Responses Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding
List pgsql-hackers
On 2018-Jun-14, Nikhil Sontakke wrote:

> There was a slight oversight in the twophase_gid length calculation in
> the XactLogCommitRecord() code path in the cf5a1890592 commit. The
> corresponding XactLogAbortRecord() code path was ok. PFA, a small
> patch to fix the oversight.

Forgot to add: maybe it would be useful to have tests in core where
these omissions become evident.  Do you have some?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Store 2PC GID in commit/abort WAL recs for logicaldecoding
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Store 2PC GID in commit/abort WAL recs for logicaldecoding