Re: pgsql: Fix and document lock handling for in-memory replicationslot da - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgsql: Fix and document lock handling for in-memory replicationslot da
Date
Msg-id 20180611214727.GA2269@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Fix and document lock handling for in-memory replicationslot da  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Mon, Jun 11, 2018 at 09:49:52AM -0700, Andres Freund wrote:
> Same is true for the codepaths calling GetRedoRecPtr().

You are right.  I'll fix in a minute.  A first commit's stress make
things really harder to get right...

> I don't object to the general idea of adding locking - although the
> benefit are nearly guaranteed to be cosmetic - but this has the
> potential to make things worse.

Thanks.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Robbie Harwood
Date:
Subject: Re: Fix some error handling for read() and errno
Next
From: Alvaro Herrera
Date:
Subject: Re: Fix some error handling for read() and errno