Re: [BUG] Re-entering malloc problem when use --enable-nlsbuildpostgresql - Mailing list pgsql-bugs

From Andres Freund
Subject Re: [BUG] Re-entering malloc problem when use --enable-nlsbuildpostgresql
Date
Msg-id 20180522211145.mpmbs2365neosqiv@alap3.anarazel.de
Whole thread Raw
In response to Re: [BUG] Re-entering malloc problem when use --enable-nls buildpostgresql  ("158306855" <anderson2013@qq.com>)
Responses Re: [BUG] Re-entering malloc problem when use --enable-nlsbuildpostgresql
List pgsql-bugs
On 2018-05-21 10:49:53 +0800, 158306855 wrote:
> > It'd be fairly unproblematic to write an untranslated message out. There
> > we can make sure to either only use plain syscalls or use memory from
> > the preallocated context.  I think it'd be ok to not to translate in
> > that situation.
> 
> 
> I wrote a patch to improve this problem.
>  
> +extern int    errmsg_no_translateit(const char *fmt,...) pg_attribute_printf(1, 2);
> +extern int    errdetail_no_translateit(const char *fmt,...) pg_attribute_printf(1, 2);
> +extern int    errhint_no_translateit(const char *fmt,...) pg_attribute_printf(1, 2);
> +
>  /*
>   * errcontext() is typically called in error context callback functions, not
>   * within an ereport() invocation. The callback function can be in a different

Can't we just reuse errmsg_internal etc?

Greetings,

Andres Freund


pgsql-bugs by date:

Previous
From: Euler Taveira
Date:
Subject: Re: crash while decoding INSERT ON CONFLICT
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: postgres_fdw misbehaviour using "DELETE ... RETURNING *"