On 2018-Mar-06, Michael Paquier wrote: > On Mon, Mar 05, 2018 at 12:57:38PM +0000, Aleksander Alekseev wrote: > > It looks like that this patch doesn't apply anymore: http://commitfest.cputube.org/ > > > > The new status of this patch is: Waiting on Author > > Yes, this happens because patch 0003 from the last series has been > committed as a26116c6. Attached is a rebased set, though the patches > have no actual changes as those are able to apply correctly. I forgot to mention this earlier: I think external FDWs do not really benefit from your 0001 (neither do most of the internal callsites of the modified functions). I checked a bunch of source files and nowhere I got a "Gee, I wish this returned InvalidOid if the object in question didn't exist" feeling. https://github.com/Kozea/Multicorn/blob/master/src/multicorn.c https://github.com/tds-fdw/tds_fdw/blob/master/src/tds_fdw.c https://github.com/pramsey/pgsql-ogr-fdw/blob/master/ogr_fdw.c https://github.com/EnterpriseDB/mysql_fdw/blob/master/mysql_fdw.c https://github.com/laurenz/oracle_fdw/blob/master/oracle_fdw.c I think we're better off adding a new function and avoid changing the signature of GetForeignServer et al. Or maybe rename the function and keep the original name as a compatibility wrapper macro. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
pgsql-hackers by date:
Соглашаюсь с условиями обработки персональных данных