Re: perlcritic and perltidy - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: perlcritic and perltidy
Date
Msg-id 20180508171858.GW27724@tamriel.snowman.net
Whole thread Raw
In response to Re: perlcritic and perltidy  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: perlcritic and perltidy  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
Andrew,

* Andrew Dunstan (andrew.dunstan@2ndquadrant.com) wrote:
> On 05/08/2018 12:51 PM, Stephen Frost wrote:
> > * Andrew Dunstan (andrew.dunstan@2ndquadrant.com) wrote:
> > There's not much point adding the ',' unless you're also putting the
> > ');' on the next line, is there..?
>
> No, not really.
>
> > Or is that going to be handled in a follow-up patch?
>
> No, the current proposal is to keep the vertical tightness settings for
> parentheses, which is precisely this set of cases, because otherwise
> there are some ugly code efects (see Peter's email upthread)
>
> So I think we're all in agreement to fortget this trailing comma thing.

Well, agreed, for parentheses, but for curly-brace blocks, it'd be nice to
have them since those will end up on their own line, right?

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: perlcritic and perltidy
Next
From: Andrew Dunstan
Date:
Subject: Re: perlcritic and perltidy