Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section
Date
Msg-id 20180427231642.GA2124@paquier.xyz
Whole thread Raw
In response to FinishPreparedTransaction missing HOLD_INTERRUPTS section  (Stas Kelvich <s.kelvich@postgrespro.ru>)
List pgsql-hackers
On Sat, Apr 28, 2018 at 12:36:16AM +0300, Stas Kelvich wrote:
> It seems that during COMMIT PREPARED FinishPreparedTransaction() doesn't
> hold interrupts around writing to wal and cleaning up ProcArray and GXact
> entries. At least RemoveTwoPhaseFile (which is called in between) can print
> a warning with ereport(), which, in turn will check for interrupts and
> therefore can cancel backend or throw an error before GXact clean-up.
>
> Other similar places like CommitTransaction and PrepareTransaction have
> such hold interrupts sections.

Good catch!  The places you are suggesting look good to me as well.
That's something which should be back-patched as well.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Postgres, fsync, and OSs (specifically linux)
Next
From: Bruce Momjian
Date:
Subject: Re: Postgres, fsync, and OSs (specifically linux)