Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as booltype - Mailing list pgsql-hackers

From Andres Freund
Subject Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as booltype
Date
Msg-id 20180427010156.p24vofp7gszxy3ie@alap3.anarazel.de
Whole thread Raw
In response to jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type  (Haribabu Kommi <kommi.haribabu@gmail.com>)
Responses Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2018-04-26 13:34:44 +1000, Haribabu Kommi wrote:
> The jitflags in the PlannedStmt structure of type "int", but in _out and
> _read functions it is treated as of "bool" type.
> 
> WRITE_BOOL_FIELD(jitFlags);
> READ_BOOL_FIELD(jitFlags);
> 
> I am thinking of it is a copy paste mistake as the other members around the
> initflags are of "bool" type or is there any specific reason to treat as
> "bool" type?

No, it's an oversight. It was a bool first and then morphed from
there... Will fix.

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Oddity in tuple routing for foreign partitions
Next
From: Andrew Gierth
Date:
Subject: Re: Toast issues with OldestXmin going backwards