Re: Gotchas about pg_verify_checksums - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Gotchas about pg_verify_checksums
Date
Msg-id 20180418000947.GA18178@paquier.xyz
Whole thread Raw
In response to Re: Gotchas about pg_verify_checksums  (Michael Banck <michael.banck@credativ.de>)
List pgsql-hackers
On Tue, Apr 17, 2018 at 09:43:47PM +0200, Michael Banck wrote:
> So I decided to add some support for earlier version in my version of
> the program, and pushed it to https://github.com/credativ/pg_checksums
> if anybody is interested in that. I have to admit that it is quite less
> fancy than your version.

Both things have the same features, except that I added as well long
options.  I can see two minor issues with your version:
1) The tool should not be allowed to run as root when using the enable
and disable modes.
2) On 11 and newer versions, you should use GetDataDirectoryCreatePerm()
to get the correct folder permissions and then set umask(pg_mode_mask).
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Should we add GUCs to allow partition pruning to be disabled?
Next
From: Michael Paquier
Date:
Subject: Re: Typos from Covering Index patch