Re: SHOW ALL does not honor pg_read_all_settings membership - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: SHOW ALL does not honor pg_read_all_settings membership
Date
Msg-id 20180417032858.GD4998@paquier.xyz
Whole thread Raw
In response to Re: SHOW ALL does not honor pg_read_all_settings membership  (Laurenz Albe <laurenz.albe@cybertec.at>)
Responses Re: SHOW ALL does not honor pg_read_all_settings membership  (Laurenz Albe <laurenz.albe@cybertec.at>)
Re: SHOW ALL does not honor pg_read_all_settings membership  (Simon Riggs <simon@2ndquadrant.com>)
List pgsql-hackers
On Mon, Apr 16, 2018 at 02:32:10PM +0200, Laurenz Albe wrote:
> Now that the dust from the last commitfest is settling, I'll make a second
> attempt to attract attention for this small bug fix.
>
> The original commit was Simon's.

Thanks for the ping.

This was new as of v10, so this cannot be listed as an open item still I
have added that under the section for older bugs, because you are right
as far as I can see.

GetConfigOption is wrong by the way, as restrict_superuser means that
all members of the group pg_read_all_settings can read
GUC_SUPERUSER_ONLY params, and not only superusers, so the comment at
least needs a fix, the variable ought to be renamed as well.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Fix slot's xmin advancement and subxact's lost snapshots indecoding.
Next
From: Euler Taveira
Date:
Subject: pg_recvlogical broken in back branches