Peter Geoghegan wrote:
> Commit 975ad4e6 fixed a nasty bug in BRIN that was
> originally found by Andreas' fuzz testing. Perhaps that bug would
> still be around if Alvaro had included any DROP statements within
> brin.sql. Presumably his choice to not to do so was completely
> arbitrary. Actually, it seems likely that it was a fortunate accident.
As I recall, it was deliberate, as I tend to do that; I did it in
indexing.sql as well, and I think in foreign_key.sql too.
These objects are also dumped/restored by pg_dump in the pg_upgrade
test.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
