Re: partitioning code reorganization - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: partitioning code reorganization
Date
Msg-id 20180414115140.3oxnddryke6rmtvq@alvherre.pgsql
Whole thread Raw
In response to Re: partitioning code reorganization  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: partitioning code reorganization  (Amit Langote <amitlangote09@gmail.com>)
Re: partitioning code reorganization  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Here's a final version.

The one thing I don't like about this is having put
PartitionRangeDatumKind in partdefs.h, which forces us to #include that
file in parsenodes.h.  I had to do this in order to avoid #including
parsenodes.h in partbounds.h.  Now maybe that is not so bad, since that
file isn't *that* widely used anyway; it wouldn't cause any unnecessary
bleeding of parsenodes.h into any other headers.  So maybe I'll put the
enum back in parsenodes.  Any opinions on that?

I intend to push this this evening.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Юрий Соколов
Date:
Subject: Re: Postgres stucks in deadlock detection
Next
From: Craig Ringer
Date:
Subject: Re: Proposal: Adding json logging