Re: Gotchas about pg_verify_checksums - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Gotchas about pg_verify_checksums
Date
Msg-id 20180410234434.GG26769@paquier.xyz
Whole thread Raw
In response to Re: Gotchas about pg_verify_checksums  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Gotchas about pg_verify_checksums
List pgsql-hackers
On Tue, Apr 10, 2018 at 02:40:58PM -0700, Peter Geoghegan wrote:
> I agree with Michael -- shutting down the server using immediate mode
> could lead to torn pages, that crash recovery will need to repair at a
> later stage. I think that some strong caveats around this are required
> in the pg_verify_checksums docs, at a minimum.

Peter, the code does the right thing as it requires the instance's
control file state to be either DB_SHUTDOWNED_IN_RECOVERY or
DB_SHUTDOWNED.  The documentation, on the contrary, implies that
the instance just needs to be offline, which can be anything as long as
the postmaster is stopped.  That's how I understand the current
wording.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: lazy detoasting
Next
From: Michael Paquier
Date:
Subject: Re: Gotchas about pg_verify_checksums