Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.hheaders. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.hheaders.
Date
Msg-id 20180410025943.GA1945@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Apr 09, 2018 at 04:46:34PM -0400, Tom Lane wrote:
> After further contemplation I decided that that was, in fact, the only
> reasonable way to improve matters.  If we have multiple subdirectories
> independently firing the "make generated-headers" action, then we have
> parallel make hazards of just the same sort I was trying to prevent.
> So it's really an all-or-nothing proposition.  The MAKELEVEL hack
> plus wiring the prerequisite into the recursion rules is the best way
> to make that happen.

Oh.  Good idea.  Thanks for the fix.  Hopefully that won't cause much
noise when bisecting bugs, this got in pretty quickly..

No more complains from here.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: ON CONFLICT DO UPDATE for partitioned tables
Next
From: Michael Paquier
Date:
Subject: Re: Warnings and uninitialized variables in TAP tests