Hi,
On 2018-03-26 13:08:01 -0300, Alvaro Herrera wrote:
> I agree -- I think logicalrep_write_attrs() should not use
> RelationGetIndexAttrBitmap at all but instead use some lower-level way
> to obtain columns of the replica identity.
Indeed.
> I don't know whether there are historical-snapshot-related
> considerations to care about, in this code, though.
There shouldn't be much of an issue if all that's accessed is system
tables/cols.
> This is neither my area nor my code, but if Petr and Peter decline
> producing a patch for this quickly, I can look at it in a few days.
Cool!
Greetings,
Andres Freund
