Greetings,
* Michael Paquier (michael@paquier.xyz) wrote:
> On Thu, Mar 08, 2018 at 10:15:11AM +0900, Michael Paquier wrote:
> > Other than that the patch looks in pretty good shape to me.
>
> The regression tests of file_fdw are blowing up because of an error
> string patch 2 changes.
Fixed in the attached.
Does anyone have an opinion regarding the adminpack functions? I was
just reviewing the patch and considering if we should adjust the
privileges there also and it seems like we should. That'd be a pretty
straight-forward change, of course, so unless there's some reason not to
then I'll see about providing an updated patch tomorrow which covers
those functions as well.
Note that it'll be a bit more complicated since we can't just remove the
checks from the existing functions- we'll need to have new functions
where the checks are removed and a new extension version that updates to
the new functions and then REVOKE's access to them. Not a big deal,
just pointing out that it's not quite as straight-forward since it's an
extension and we need to deal with environments where the server's been
upgraded and the .so changed, but the existing functions are still in
place with their current public-execute rights.
Thanks!
Stephen
