Re: pgsql: Remove pg_class.relhaspkey - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Remove pg_class.relhaspkey
Date
Msg-id 20180314211344.3x2bhr7bmqmtvor6@alap3.anarazel.de
Whole thread Raw
In response to pgsql: Remove pg_class.relhaspkey  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: pgsql: Remove pg_class.relhaspkey
Re: pgsql: Remove pg_class.relhaspkey
List pgsql-committers
Hi,

On 2018-03-14 19:35:40 +0000, Peter Eisentraut wrote:
> Remove pg_class.relhaspkey
> 
> It is not used for anything internally, and it cannot be relied on for
> external uses, so it can just be removed.  To correct recommended way to
> check for a primary key is in pg_index.
> 
> Discussion: https://www.postgresql.org/message-id/flat/b1a24c6c-6913-f89c-674e-0704f0ed69db@2ndquadrant.com

I'm not clear on the mechanics, and the animal doesn't show the critical
log. But this might have caused the issue, being the only commit between
runs:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2018-03-14%2019%3A37%3A20

Andrew, any chance you could modify the module to capture
pg_upgrade_dump_*.log?

Greetings,

Andres Freund


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Support INOUT arguments in procedures
Next
From: Stephen Frost
Date:
Subject: Re: pgsql: Remove pg_class.relhaspkey