Re: PATCH: Unlogged tables re-initialization tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: PATCH: Unlogged tables re-initialization tests
Date
Msg-id 20180311091149.GB5399@paquier.xyz
Whole thread Raw
In response to Re: PATCH: Unlogged tables re-initialization tests  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: PATCH: Unlogged tables re-initialization tests
List pgsql-hackers
On Fri, Mar 09, 2018 at 05:23:48PM -0500, Peter Eisentraut wrote:
> This seems like a useful test.
>
> On 3/5/18 12:35, David Steele wrote:
> > +mkdir($tablespaceDir)
> > +    or die "unable to mkdir \"$tablespaceDir\"";
>
> Use BAIL_OUT instead of die in tests.

Would it be better to make this practice more uniform?  From the code of
the tests:
$ git grep die -- */t/*.pl | wc -l
50
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: Bogus use of canonicalize_qual
Next
From: Dean Rasheed
Date:
Subject: Re: MCV lists for highly skewed distributions