Re: Rewrite of pg_dump TAP tests - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Rewrite of pg_dump TAP tests
Date
Msg-id 20180307121249.GC2416@tamriel.snowman.net
Whole thread Raw
In response to Re: Rewrite of pg_dump TAP tests  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Rewrite of pg_dump TAP tests  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Michael,

* Michael Paquier (michael@paquier.xyz) wrote:
> On Tue, Mar 06, 2018 at 11:53:41AM -0500, Stephen Frost wrote:
> > * Stephen Frost (sfrost@snowman.net) wrote:
> >> Attached is a patch (which applies cleaning against a2a2205, but not so
> >> much anymore, obviously, but I will fix after the releases) which
> >> greatly improves the big pg_dump TAP tests.  There's probably more which
> >> can be done, but I expect people will be much happier with this.  The
> >> cliff-notes are:
> >
> > Attached is an updated patch which applies cleanly against current
> > master.  I've not yet looked into back-patching these changes, but will
> > if this can get some review and feedback, and folks like this better and
> > are ok with the same being done in the back-branches.
>
> It would be nice to improve the readability of test_pg_dump's
> 001_base.pl at the same time by using similarly a hash syntax for common
> options.

Yes, good point, will fix.

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
Next
From: Stephen Frost
Date:
Subject: Re: public schema default ACL