Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw - Mailing list pgsql-hackers

From Arthur Zakirov
Subject Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw
Date
Msg-id 20180306140024.GA12795@zakirov.localdomain
Whole thread Raw
In response to Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
On Tue, Mar 06, 2018 at 08:09:50PM +0900, Etsuro Fujita wrote:
> Agreed.  I added a comment to that function.  I think that that comment in
> combination with changes to the FDW docs in the patch would help FDW authors
> understand why that is needed.  Please find attached an updated version of
> the patch.

Thank you.

All tests pass, the documentation builds. There was the suggestion [1]
of different approach. But the patch fix the issue in much more simple
way.

Marked as "Ready for Commiter".


1 - https://www.postgresql.org/message-id/20171005.200631.134118679.horiguchi.kyotaro%40lab.ntt.co.jp

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


pgsql-hackers by date:

Previous
From: Ildar Musin
Date:
Subject: Re: General purpose hashing func in pgbench
Next
From: David Steele
Date:
Subject: Re: Re: [PATCH] Atomic pgrename on Windows