Re: Online enabling of checksums - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Online enabling of checksums
Date
Msg-id 20180228194242.qbjasdtwm2yj5rqg@alvherre.pgsql
Whole thread Raw
In response to Re: Online enabling of checksums  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Online enabling of checksums  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Re: Online enabling of checksums  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
I noticed that pg_verify_checksum takes an "-o oid" argument to only
check the relation with that OID; but that's wrong, because the number
is a relfilenode, not an OID (since it's compared to the on-disk file
name).  I would suggest changing everything to clarify that it's a
pg_class.relfilenode value, otherwise it's going to be very confusing.
Maybe use "-f filenode" if -f is available?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: handling of heap rewrites in logical decoding
Next
From: Peter Eisentraut
Date:
Subject: PL/pgSQL nested CALL with transactions