Re: Let's remove DSM_INPL_NONE. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Let's remove DSM_INPL_NONE.
Date
Msg-id 20180228005732.GA1476@paquier.xyz
Whole thread Raw
In response to Re: Let's remove DSM_INPL_NONE.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Feb 27, 2018 at 02:00:36PM -0500, Robert Haas wrote:
> I think the two issues you are pointing out are the same issue --
> namely, if initdb probes for a max_connections setting with an invalid
> DSM implementation configured, it will fail the test for every value
> of max_connections and thus select the lowest possible value.  The
> solution to this is presumably just to make sure we choose the DSM
> implementation before we do the max_connections probing so that we can
> pass through the correct value there, which I think is what your patch
> does.

Yes, that's what the thing does.  It moves the routine to find the DSM
implementation before computing max_connections.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: ON CONFLICT DO UPDATE for partitioned tables
Next
From: Michael Paquier
Date:
Subject: Re: Let's remove DSM_INPL_NONE.