Re: MSVC builld of 9.5.12 is broken? - Mailing list pgsql-hackers

From Victor Wagner
Subject Re: MSVC builld of 9.5.12 is broken?
Date
Msg-id 20180227154240.20aa1222@fafnir.local.vm
Whole thread Raw
In response to Re: MSVC builld of 9.5.12 is broken?  (Magnus Hagander <magnus@hagander.net>)
Responses Re: MSVC builld of 9.5.12 is broken?  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Tue, 27 Feb 2018 11:43:34 +0100
Magnus Hagander <magnus@hagander.net> wrote:


> I'm unsure why this was introduced in 9.5 and earlier, but not in the
> newer ones.  This smells like a possible backpatch mistake, in which
> case that part should probably be backed out of the old branches
> rather than teaching mkvcbuild about it.

Patch for Mkvcbuild.pm is actually quite simple (see attach).

Really, I have more complicated patch, which supports recursive
substitution as gmake does. It was developed to simplify inclusion of
PGXS extensions into contrib tree. (authors of modern extension often
use complex Makefile constructs).

I've not presented it to community because I hoped that current MSVC
build system would be soon replaced by cmake.

-- 



Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: MSVC builld of 9.5.12 is broken?
Next
From: Magnus Hagander
Date:
Subject: Re: MSVC builld of 9.5.12 is broken?