Postgres Pro
Downloads
Home   >   mailing lists

Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAPsupport - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAPsupport
Date
Msg-id 20180216233441.GA21104@paquier.xyz
Whole thread Raw
In response to Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAPsupport  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAPsupport
List pgsql-hackers
Tree view 
On Fri, Feb 16, 2018 at 03:32:46PM -0500, Peter Eisentraut wrote:
> Maybe that would work.
>
> We still need a way to configure whether we want to run tests that open
> TCP/IP listen sockets.

For this an environment variable seems suited to me.  Say if
PG_TAP_ALLOW_INSECURE is set, then the tests said "insecure" are allowed
to run.  If the tests are tried to be run, then they are just skipped
with a nice log message to tell you about it.  The cool part about this
design is that all the tests that are not part of check-world could be
integrated in it.  Most developers don't run regression tests on a
shared resource.  Let me think about a full-fledged patch first.
Documentation also matters a lot.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: ALTER TABLE ADD COLUMN fast default
Next
From: Arseny Sher
Date:
Subject: Re: Server Crash while executing pg_replication_slot_advance (second time)