Re: [HACKERS] Creating backup history files for backups taken fromstandbys - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Creating backup history files for backups taken fromstandbys
Date
Msg-id 20180202050650.GA5451@paquier.xyz
Whole thread Raw
In response to Re: [HACKERS] Creating backup history files for backups taken from standbys  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: [HACKERS] Creating backup history files for backups taken from standbys  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Fri, Feb 02, 2018 at 12:47:26AM +0900, Fujii Masao wrote:
> The patch basically looks good to me. Here are some small comments.
>
>    <para>
>       The backup history file is not created in the database cluster backed up.
>    </para>
>
> The above should be deleted in pg_basebackup.sgml.
>
>     * During recovery, since we don't use the end-of-backup WAL
>     * record and don't write the backup history file, the
>
> This comment needs to be updated in xlog.c.

Thanks Fujii-san for the review.  Indeed those portions need a refresh..
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PoC PATCH] Parallel dump to /dev/null
Next
From: Thomas Munro
Date:
Subject: Re: JIT compiling with LLVM v9.0