Re: make_etags: avoid recursive symbolic creation. - Mailing list pgsql-hackers

From David Fetter
Subject Re: make_etags: avoid recursive symbolic creation.
Date
Msg-id 20180119015131.GW4221@fetter.org
Whole thread Raw
In response to make_etags: avoid recursive symbolic creation.  (Ashwin Agrawal <aagrawal@pivotal.io>)
List pgsql-hackers
On Thu, Jan 18, 2018 at 03:58:31PM -0800, Ashwin Agrawal wrote:
> src/tools/make_etags creates link to TAGS file from each and every
> directory in source tree. It works fine without all those links in each and
> every directory in source code so remove the extra work and annoyance.
> 
> diff --git a/src/tools/make_etags b/src/tools/make_etags
> index 3ce96bc3ca..2bfd1314fe 100755
> --- a/src/tools/make_etags
> +++ b/src/tools/make_etags
> @@ -6,8 +6,3 @@ rm -f ./TAGS
> 
>  find `pwd`/ -type f -name '*.[chyl]' -print |
>         xargs etags --append -o TAGS
> -
> -find . \( -name CVS -prune \) -o \( -name .git -prune \) -o -type d -print
> |
> -while read DIR
> -do     [ "$DIR" != "." ] && ln -f -s `pwd`/TAGS "$DIR"
> -done

My understanding of this and of the analogous structure in make_ctags
is to accommodate people who hadn't tuned up their text editor to do
the right thing.  If we're going to revisit this, we should do both or
neither.

I'm for removing both and adding some minimal explanation of how not
to need the tags files all over the tree.

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add default role 'pg_access_server_files'
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)