Re: [PATCH] Atomic pgrename on Windows - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [PATCH] Atomic pgrename on Windows
Date
Msg-id 20180115024230.GH2416@tamriel.snowman.net
Whole thread Raw
In response to [PATCH] Atomic pgrename on Windows  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-hackers
Greetings Alexander, all,

* Alexander Korotkov (a.korotkov@postgrespro.ru) wrote:
> Attached patch atomic-pgrename-windows-1.patch fixes this problem.  It
> appears to be possible to atomically replace file on Windows –
> ReplaceFile() does that.  ReplaceFiles() requires target file to exist,
> this is why we still need to call MoveFileEx() when it doesn't exist.

There's been some discussion on this patch and it seems to, at least,
improve the situation on Windows even if it might not completely address
the issues.  Does anyone else want to take a look and comment,
particularly those familiar with the Windows side of things?  Otherwise,
I'm afraid this patch may end up just sitting in Needs review state fo
the entire CF and not getting moved forward, even though it seems like a
good improvement for our Windows users.

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] Useless code in ExecInitModifyTable
Next
From: Andres Freund
Date:
Subject: Re: PATCH: psql tab completion for SELECT