Re: [HACKERS] Adding column_constraint description in ALTER TABLEsynopsis - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [HACKERS] Adding column_constraint description in ALTER TABLEsynopsis
Date
Msg-id 20180115013220.GE2416@tamriel.snowman.net
Whole thread Raw
In response to Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis  (Lætitia Avrot <laetitia.avrot@gmail.com>)
Responses Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis
List pgsql-hackers
Greetings Lætitia, Amit,

* Lætitia Avrot (laetitia.avrot@gmail.com) wrote:
> Thanks Stephen for the suggestion. I wan't thinking globally enough. I was
> planning to look at it today but Amit was faster. So thanks Amit too!

This seems to have gotten lost in the shuffle, but Amit's patch still
applies cleanly and it looks like a good patch to me, so I've added it
to the current CF and marked it as Needs Review.  There's been some
further discussion of this change over in this thread:


https://www.postgresql.org/message-id/flat/20171220090816.25744.72592%40wrigleys.postgresql.org#20171220090816.25744.72592@wrigleys.postgresql.org

which seemed to reach the conclusion that the proposed patch makes
sense.

If someone else would like to review it, that'd be great, otherwise I'll
probably get it committed soon.

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: PATCH: psql tab completion for SELECT
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Refactoring identifier checks to consistently usestrcmp